-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambda thermalq #362
Add lambda thermalq #362
Conversation
Looks like this breaks the python bindings somehow. I don't think it should be too hard to fix.
Can you run on gitlab as well just to make sure it doesn't break anything else? |
|
Thanks @jhp-lanl @dholladay00 should be fixed now. Tests running on re-git. |
OK not sure why the python bindings are still failing... @rbberger any insight? |
Maybe because |
Hmm... possible. I'll try |
That worked! Thanks @rbberger ! Ok tests now all apss here. Checking on re-git as well. Ready for re-review, @dholladay00 @gopsub @jhp-lanl @rbberger |
Looks like tests are still failing on Roci due to a failed git clone. (@rbberger is this expected? Maybe related to the issues @dholladay00 reported on the mattermost?) However, everything else is passing. I think it's safe to review this and merge it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
PR Summary
As discussed with @dholladay00 and @gopsub , this adds
lambda
to thethermalq
s list, allowing, on a per-EOS basis, users to requestFillEos
to do something with input lambdas.PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: