Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gold files #343

Merged
merged 2 commits into from
Feb 12, 2024
Merged

update gold files #343

merged 2 commits into from
Feb 12, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

PR #338 pulls in additional data from the files, which wasn't included in the synthetic gold files. This PR adds the relevant data to the gold file generator script and points to the new goldfile.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@Yurlungur Yurlungur added the Testing Additions/changes to the testing infrastruture label Feb 12, 2024
@Yurlungur Yurlungur requested a review from brryan February 12, 2024 21:04
@Yurlungur Yurlungur self-assigned this Feb 12, 2024
@Yurlungur
Copy link
Collaborator Author

Note that if we ever encounter stellar collapse files in the wild missing chemical potentials, we will need to add some error handling in the stellar collapse class itself.

Copy link
Collaborator

@AstroBarker AstroBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@Yurlungur Yurlungur merged commit f379be5 into main Feb 12, 2024
4 checks passed
@Yurlungur Yurlungur deleted the jmm/update-stellar-collapse-gold branch February 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Additions/changes to the testing infrastruture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants