Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spackage with Plugin support #337

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Spackage with Plugin support #337

merged 4 commits into from
Jan 29, 2024

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Jan 25, 2024

PR Summary

This updates the Singularity-EOS spackage to support plugins. It introduces a new directive singularity_eos_plugin which is used to register a plugin with a relative plugin path. While convenient, we still have to see if spack upstream would accept such a spackage change.

The plugins variant can then choose one or more of these plugins to be used. Unknown plugin names will result in an error.

variant can be used to set the variant header location.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@rbberger rbberger force-pushed the plugin_enabled_spackage branch from e05811a to 1c5eacf Compare January 25, 2024 06:34
@rbberger rbberger force-pushed the plugin_enabled_spackage branch from 1c5eacf to 577194a Compare January 25, 2024 06:38
@rbberger rbberger marked this pull request as ready for review January 25, 2024 20:52
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @mauneyc-LANL should probably also take a look

spack-repo/packages/singularity-eos/package.py Outdated Show resolved Hide resolved
@rbberger rbberger force-pushed the plugin_enabled_spackage branch from 8208662 to f9158b2 Compare January 26, 2024 18:59
@mauneyc-LANL mauneyc-LANL self-requested a review January 29, 2024 17:28
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbberger one more minor comment. Then from my perspective this is good to g. Since @mauneyc-LANL also agrees, go ahead and pull the trigger when you're ready. (Or ask me or @dholladay00 to do so.)

spack-repo/packages/singularity-eos/package.py Outdated Show resolved Hide resolved
@Yurlungur Yurlungur merged commit f732181 into main Jan 29, 2024
4 checks passed
@Yurlungur Yurlungur deleted the plugin_enabled_spackage branch January 29, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants