Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This updates the Singularity-EOS spackage to support plugins. It introduces a new directive
singularity_eos_plugin
which is used to register a plugin with a relative plugin path. While convenient, we still have to see if spack upstream would accept such a spackage change.The
plugins
variant can then choose one or more of these plugins to be used. Unknown plugin names will result in an error.variant
can be used to set the variant header location.PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: