Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing header in CMake install #335

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

AlexHls
Copy link
Collaborator

@AlexHls AlexHls commented Jan 22, 2024

PR Summary

Adds a missing hermite.hpp header to the EOS_HEADERS variable. Required for the Helmholtz EOS in standalone mode.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@mauneyc-LANL mauneyc-LANL merged commit f097b44 into main Jan 22, 2024
4 checks passed
@mauneyc-LANL mauneyc-LANL deleted the alexhls/helmholtz-fix-install branch January 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants