-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piecewise grids for spiner EOS #330
Conversation
…eos into jmm/hierarchical-grids
…eos into jmm/hierarchical-grids
…eos into jmm/hierarchical-grids
…eos into jmm/hierarchical-grids
@jhp-lanl @dholladay00 @chadmeyer this is ready for review. I think there's more one can do in this space, but IMO this is a nice start. In particular, energy and pressure near normal density are significantly better resolved with this method. In anticipation of enabling spiner tables to load data from another eos, I move the I also found and fixed the issue @pdmullen found in riot regarding extrapolation. It was a bizarre interaction between fast logs and eospac in |
Thanks, @jhp-lanl !
Yep already on that. The existing tests do cover this on re-git. So it's very important those get run before final merge. |
@dholladay00 please review. @chadmeyer please re-review or click approve depending. |
(tests now all passing on re-git.) |
|
||
static void adjustForAnchor_(const Real min, Real &max, int &N, | ||
const Real anchor_point) { | ||
if (min < anchor_point && anchor_point < max) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the implications if this condition isn't met, would it make sense to error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the condition isn't met, it will just not adjust the number of points or the max. The table will still be valid, but there won't be a grid point exactly at the anchor point. I'd like sesame2spiner
to basically always run... so I'd rather this not error out. But I'll add a warning.
Thanks @dholladay00 I think I've addressed all your comments. Can you click approve if you agree? (I will not merge until post-change tests all pass on re-git) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good now for pushing. Good Job @Yurlungur!
Thanks @chadmeyer @jhp-lanl @dholladay00 for your reviews! I now plan to merge as soon as the latest commit passes tests on re-git. Speak now if you have objections. :) |
#endif | ||
|
||
constexpr int NGRIDS = 3; | ||
using Bounds = singularity::table_utils::Bounds<NGRIDS>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yurlungur since the Bounds
class depends on spiner
, can you wrap all of this in a SINGULARITY_USE_SPINER
#ifdef
?
I'm failing to build the tests when SINGULARITY_USE_SPINER
is off.
I'll create an issue too.
PR Summary
PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: