Add error check after 'eosCreateTables()' in the 'eosSafeLoad()' function

[jhp-lanl]

PR Summary

Fixes a bug when the comment table wasn't available. The eosCreateTables() function would return an error code, but the code wouldn't be handled. This change adds an early return to skip the eosLoadTables() call if eosCreateTables() fails.

EDIT - An additional check was needed for when the comment table is created but when the error code returned is okay. The comments table could still be invalid and so the length needs to be checked before trying to extract comments.

I think this should help address a bug found by @annapiegra where a comments table length would be negative when a comments table didn't exist, and would cause issues for the comments vector later on when the resize() member is called.

PR Checklist

• Adds a test for any bugs fixed. Adds tests for new features.
• Format your changes by using the make format command after configuring with cmake.
• Document any new features, update documentation for changes made.
• Make sure the copyright notice on any files you modified is up to date.
• After creating a pull request, note it in the CHANGELOG.md file
• If preparing for a new release, update the version in cmake.

[annapiegra]

This doesn't solve the issue since commentLen is returned from eosSafeTableInfo. Initializing commentLen to 0 would be a possible solution (in the current implementation if the info returns an error commentLen keeps a garbage value)

[jhp-lanl]

This doesn't solve the issue since commentLen is returned from eosSafeTableInfo. Initializing commentLen to 0 would be a possible solution (in the current implementation if the info returns an error commentLen keeps a garbage value)

@annapiegra let me know if this fixes it

[Yurlungur]

Thanks for fixing this @jhp-lanl this one is an interesting edge case.

[jhp-lanl]

These were minor changes, but it still feels good to have the format check pass without having to run the format tool 😁

[annapiegra]

Works now. Thanks!