-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast logs in stellar collapse #295
Conversation
…iltering bmod before re-interpolating
…nges of the databoxes in LoadFromStellarCollapseFile_
…now should be a switch flip to jump to fast logs.
FYI @brryan @AstroBarker |
…ularity-eos into jmm/fast-logs-stellar-collapse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions but I'll approve now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Yurlungur ! LGTM
How does this perform both speed/accuracy vs the previous implementation @Yurlungur ? |
@dholladay00 @jhp-lanl @brryan I believe all comments have been addressed.
In principle, there's no error due to the fast log gridding. However, reinterpolation introduces an error proportional to 1/(ngrid points0^2. Performance improvement of P(rho, T) is a factor of a few, similar to what we saw with the SpinerEOS for sesame tables. T(rho, e) shows a 20% or so performance improvement. |
@Yurlungur it looks like the python tests are failing. Could be some of the stellarcollapse changes weren't propagated. |
Yep I see. That's exactly what it is. I'll take a look. |
This is now passing CI. |
Thanks for the fix @dholladay00 ! I'll go ahead and merge this then. |
PR Summary
For a while, I've been meaning to pull the fast logs code through the stellar collapse EOS model, as well as the singularity-opac models. This PR implements the first part of that. I thread fast logs through the stellar collapse eos. A few notes:
StellarCollapse
supports reading eithersp5
files orh5
files in original stellar collapse format. I maintain that capability, and add machinery to re-interpolate the the stellar collapse files to the new fast log grid. That said, this means loading from h5 files will be even slower, and loading from sp5 files for production is highly recommended.PR Checklist
make format
command after configuring withcmake
.