-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bjm/carnstar #292
Bjm/carnstar #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. A few minor nitpicks/comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to go. I'm running tests on re-git.
Nevermind---tests are failing. Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay but with the super computers down I was able to review this finally
@jonahm-LANL sorry for not being clear, but I was trying to debug the gitlab pipeline failures on device through the gitlab CI. It's possible my last fix may have been enough, but we'll need to wait to find out when the merge pipeline finishes. If it fails I'll make a new MR to fix the issue |
It also needs to be updated to take indexers. |
Oops sorry about that. |
This adds the quasi-exact Carnahan-Starling EOS from Burnett (2018) Verification Studies for the Noh Problem using Non-ideal Equations of State and Finite Strength Shocks
PR Summary
PR Checklist
make format
command after configuring withcmake
.