Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bjm/carnstar #292

Merged
merged 23 commits into from
May 31, 2024
Merged

Bjm/carnstar #292

merged 23 commits into from
May 31, 2024

Conversation

c0sm0-kramer
Copy link
Collaborator

@c0sm0-kramer c0sm0-kramer commented Aug 10, 2023

This adds the quasi-exact Carnahan-Starling EOS from Burnett (2018) Verification Studies for the Noh Problem using Non-ideal Equations of State and Finite Strength Shocks

PR Summary

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. A few minor nitpicks/comments below.

singularity-eos/eos/eos_carnahan_starling.hpp Outdated Show resolved Hide resolved
singularity-eos/eos/eos_carnahan_starling.hpp Outdated Show resolved Hide resolved
singularity-eos/eos/eos_carnahan_starling.hpp Show resolved Hide resolved
singularity-eos/eos/eos_carnahan_starling.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to go. I'm running tests on re-git.

@Yurlungur
Copy link
Collaborator

Nevermind---tests are failing. Looks like MinInternalEnergyFromDensity is not present. @jhp-lanl do you know what the value should be?

Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay but with the super computers down I was able to review this finally

singularity-eos/eos/eos_noble_abel.hpp Show resolved Hide resolved
@Yurlungur Yurlungur merged commit 6cc0ba7 into main May 31, 2024
5 checks passed
@Yurlungur Yurlungur deleted the bjm/carnstar branch May 31, 2024 17:35
@jhp-lanl
Copy link
Collaborator

@jonahm-LANL sorry for not being clear, but I was trying to debug the gitlab pipeline failures on device through the gitlab CI. It's possible my last fix may have been enough, but we'll need to wait to find out when the merge pipeline finishes.

If it fails I'll make a new MR to fix the issue

@dholladay00
Copy link
Collaborator

It also needs to be updated to take indexers.

@Yurlungur
Copy link
Collaborator

Oops sorry about that.

@Yurlungur Yurlungur restored the bjm/carnstar branch May 31, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants