-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration export #290
Conversation
It blows my mind that with how much boilerplate this has that there isn't already CMake functionality for this. And I don't want to block anything, but would it make sense for this to be a macro wrapping |
@mauneyc-LANL do we need to run the CI on gitlab as well? |
Probably this should be used. I can do this for this PR or later |
There's no test for this on the CI; there's been some discussion on doing this and maybe should plan for it. Locally I just copy the examples folder and have a CMake with |
@jhp-lanl I've updated to use |
Okay the CMake configure stage seems to work now (which is where I was seeing the failure before). Merging |
PR Summary
@jhp-lanl found an issue where the exported
singularity-eosConfig.cmake
didn't have guards to check if a target has already been created for dependencies. This would cause an issue with builds where there are common dependencies downstream.This update includes those guards, and also simplifies the logic.
PR Checklist
make format
command after configuring withcmake
.