Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interpolation of mass fractions #263

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix interpolation of mass fractions #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df80c33
fix interpolation of mass fractions
jonahm-LANL Jun 1, 2023
a9b686c
CHANGELOG
jonahm-LANL Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Current develop

### Fixed (Repair bugs, etc)
- [[PR263]](https://github.com/lanl/singularity-eos/pull/263) Fix stellar collapse mass fraction interpolation
- [[PR258]](https://github.com/lanl/singularity-eos/pull/258) Fix EOSPAC vector performance and add warnings when slower version gets selected.
- [[PR243]](https://github.com/lanl/singularity-eos/pull/243) Remove undefined behavior caused by diagnostic variables. Also fixed some compiler warnings.
- [[PR239]](https://github.com/lanl/singularity-eos/pull/239#issuecomment-1473166925) Add JQuery to dependencies for docs to repair build
Expand Down
12 changes: 6 additions & 6 deletions singularity-eos/eos/eos_stellar_collapse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,12 +604,12 @@ void StellarCollapse::MassFractionsFromDensityTemperature(
Real &Abar, Real &Zbar, Real *lambda) const {
Real lRho, lT, Ye;
getLogsFromRhoT_(rho, temperature, lambda, lRho, lT, Ye);
Xa = Xa_.interpToReal(Ye, lRho, lT);
Xh = Xh_.interpToReal(Ye, lRho, lT);
Xn = Xn_.interpToReal(Ye, lRho, lT);
Xp = Xp_.interpToReal(Ye, lRho, lT);
Abar = Abar_.interpToReal(Ye, lRho, lT);
Zbar = Zbar_.interpToReal(Ye, lRho, lT);
Xa = Xa_.interpToReal(Ye, lT, lRho);
Xh = Xh_.interpToReal(Ye, lT, lRho);
Xn = Xn_.interpToReal(Ye, lT, lRho);
Xp = Xp_.interpToReal(Ye, lT, lRho);
Abar = Abar_.interpToReal(Ye, lT, lRho);
Zbar = Zbar_.interpToReal(Ye, lT, lRho);
}

PORTABLE_INLINE_FUNCTION
Expand Down