Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOSPAC vector performance #258

Merged
merged 3 commits into from
May 18, 2023
Merged

EOSPAC vector performance #258

merged 3 commits into from
May 18, 2023

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented May 18, 2023

PR Summary

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@rbberger rbberger requested a review from jhp-lanl May 18, 2023 21:57
rbberger added 2 commits May 18, 2023 15:59
- prevents slower template to become active in some cases
- adds a warning if slower non scratch version gets called
@rbberger rbberger force-pushed the rberger_eospac_performance branch from 7e519d1 to 6549024 Compare May 18, 2023 22:00
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix, @rbberger ! Can you add the PR to the changelog as well? After @jhp-lanl approves, I think this is ready for merge.

Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once you add a changelog entry I think this is good to go. Thanks @rbberger !

@rbberger
Copy link
Collaborator Author

@Yurlungur @jhp-lanl done.

@Yurlungur
Copy link
Collaborator

Waiting for tests to pass, then will merge.

@Yurlungur Yurlungur merged commit 6d91f5d into main May 18, 2023
@Yurlungur Yurlungur deleted the rberger_eospac_performance branch May 18, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOSPAC performance could be hit significantly when passing the wrong types
3 participants