Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mass fractions to stellarcollapse #250

Merged
merged 3 commits into from
Apr 6, 2023
Merged

add mass fractions to stellarcollapse #250

merged 3 commits into from
Apr 6, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Apr 6, 2023

PR Summary

This is a feature needed by NGP code Phoebus, which provides additional astrophysical data tabulated in the stellar collapse table. It should have no effect unless a user specifically pulls a StellarCollapse equation of state out of the variant.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur added the enhancement New feature or request label Apr 6, 2023
@Yurlungur Yurlungur self-assigned this Apr 6, 2023
Copy link
Collaborator

@AstroBarker AstroBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this!

@dholladay00
Copy link
Collaborator

LGTM assuming CI passes.

@Yurlungur Yurlungur merged commit 6b67735 into main Apr 6, 2023
@Yurlungur Yurlungur deleted the jmm/mass-fractions branch April 6, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants