dholladay00/separate get sg eos #245

dholladay00 · 2023-03-27T18:50:18Z

PR Summary

This is the first step to separating out EAP specific code from singularity-eos.
This has the added benefit that it enables less robust compilers (xl and early hip compilers) to build the code.

PR Checklist

Adds a test for any bugs fixed. Adds tests for new features.
Format your changes by using the make format command after configuring with cmake.
Document any new features, update documentation for changes made.
Make sure the copyright notice on any files you modified is up to date.
After creating a pull request, note it in the CHANGELOG.md file
If preparing for a new release, update the version in cmake.

…unit. This is the first step to moving that code out of sg-eos.

jhp-lanl · 2023-03-27T19:16:47Z

thanks @dholladay00 ! Let us know when it's ready for review

…y needed in the new file.

…es. Add no warn to eospac on gpus to reduce known and not useful warnings.

Yurlungur

👍 Nice. Looking forward to merging this in.

singularity-eos/eos/eos_eospac.hpp

singularity-eos/eos/get_sg_eos.cpp

singularity-eos/eos/get_sg_eos_lambdas.hpp

…wlines cannot be generated by macros.

…le time.

… remove warnings.

… performance in this case, but it demonstrates correct usage and paves the way for future streams usaged via kokkos partition space.

…withdebinfo

…, less hostdevice, and more warning suppression.

…ould improve build times for native c++ projects. Remove unused variable.

…should get rid of those.

singularity-eos/CMakeLists.txt

singularity-eos/eos/eos_eospac.hpp

singularity-eos/eos/modifiers/ramps_eos.hpp

Yurlungur · 2023-08-08T18:42:09Z

@dholladay00 this is still marked as a draft. Is that still the case?

…ect build restrictions that reduce compile times. PTE tests still built under normal conditions.

…_get_sg_eos

…long compile timesgit status Removing unnecessary function args.

…d tests. Now only builds with closure and fortran.

dholladay00 · 2023-08-16T19:40:59Z

Everything is passing. Clicking the button.

dholladay00 added 3 commits March 23, 2023 14:49

Initial commit on splitting out get_sg_eos to a separate compilation …

289f39c

…unit. This is the first step to moving that code out of sg-eos.

Merge main.

e56b44b

format.

4c948da

dholladay00 added 2 commits March 27, 2023 13:19

Included file locations moved to correct place, mixed cell models onl…

8ba8a2a

…y needed in the new file.

format

ef62d59

dholladay00 changed the title ~~Draft:dholladay00/separate get sg eos~~ Draft: dholladay00/separate get sg eos Mar 27, 2023

dholladay00 and others added 2 commits April 17, 2023 17:46

Merge branch 'main' into dholladay00/separate_get_sg_eos

27a66ee

Split get sg eos into several compilation units to reduce compile tim…

fffa84c

…es. Add no warn to eospac on gpus to reduce known and not useful warnings.

Yurlungur reviewed Apr 25, 2023

View reviewed changes

singularity-eos/eos/eos_eospac.hpp Show resolved Hide resolved

singularity-eos/eos/get_sg_eos.cpp Outdated Show resolved Hide resolved

singularity-eos/eos/get_sg_eos_lambdas.hpp Outdated Show resolved Hide resolved

dholladay00 added 20 commits April 25, 2023 14:27

Fixing non-kokkos build issues.

98ad54c

Formatting.

4d35a16

guard the nowarn.

da798cc

remove erroneous pragma from copy-paste.

c5df26b

Added missing portable function.

acd3349

More missing function decorators.

1fbcfac

Minor syntax change to preprocessor logic.

54dfeec

Make macro on new line.

de35b08

The macro I created won't work b/c the pragma needs a new line and ne…

7f1997a

…wlines cannot be generated by macros.

Removed commented out code, get rid of warnings, try to improve compi…

30de7d3

…le time.

Remove rdc references in spackages and cmake files.

53ef4db

Make modifier checking/modification functionality inline constexpr to…

cf23fd5

… remove warnings.

Reverting template parameters, this change was an incorrect change.

e196b55

Using execution space arguments for deep copies. This may not improve…

be1268d

… performance in this case, but it demonstrates correct usage and paves the way for future streams usaged via kokkos partition space.

Merge main, resolve conflict.

2080ef6

Format

ecff459

Make cuda builds release and everything else the default value of rel…

52dc1c9

…withdebinfo

fix mistakes in gitlab changes.

9151751

Updating the cuda compatibility patch to make more usage of constexpr…

3f2cbf9

…, less hostdevice, and more warning suppression.

Moving to earlier cuda versions that passed tests.

ea59f83

dholladay00 added 8 commits August 3, 2023 09:37

Merge main.

4fd4cfd

Only build the get_sg files when closure and (fortran or testing), sh…

63456b3

…ould improve build times for native c++ projects. Remove unused variable.

Fix more warnings. Some related to capturing this in modifiers, this …

f7736f8

…should get rid of those.

Fix ci warnings + format.

0aab253

try to fix warning.

1f77a51

Remove unused variables.

1d4fc85

Merge branch 'main' into dholladay00/separate_get_sg_eos

3748a69

format.

0dd0268

mauneyc-LANL approved these changes Aug 4, 2023

View reviewed changes

Merge branch 'main' into dholladay00/separate_get_sg_eos

ed4e55a

Yurlungur approved these changes Aug 8, 2023

View reviewed changes

singularity-eos/CMakeLists.txt Outdated Show resolved Hide resolved

singularity-eos/eos/eos_eospac.hpp Show resolved Hide resolved

singularity-eos/eos/modifiers/ramps_eos.hpp Show resolved Hide resolved

mauneyc-LANL changed the title ~~Draft: dholladay00/separate get sg eos~~ dholladay00/separate get sg eos Aug 9, 2023

dholladay00 added 14 commits August 14, 2023 12:14

Test refactor. The getsgeos tests are now in their own file that resp…

9774621

…ect build restrictions that reduce compile times. PTE tests still built under normal conditions.

Merge branch 'main' into dholladay00/separate_get_sg_eos

c9823d2

Format.

bdf02e3

Switch from lambdas with macros to functors.

a77b090

Merg main.

0e37800

Merge branch 'main' into dholladay00/cleanup_variadic

4179042

Merge branch 'dholladay00/cleanup_variadic' into dholladay00/separate…

7129f96

…_get_sg_eos

Using individual functions instead of ptofre, this was the source of …

ff334d2

…long compile timesgit status Removing unnecessary function args.

Change file name to reflect move from lambdas to functors.

4b6c859

Remove unused variables.

a225052

Merge branch 'main' into dholladay00/separate_get_sg_eos

5ad4058

format.

55ceed2

Correct cmake logic for get_sg_eos. Previously, built with closure an…

305f7e6

…d tests. Now only builds with closure and fortran.

Edit changelog.

ed5a121

dholladay00 merged commit dd5d8d4 into main Aug 16, 2023

dholladay00 deleted the dholladay00/separate_get_sg_eos branch August 16, 2023 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dholladay00/separate get sg eos #245

dholladay00/separate get sg eos #245

dholladay00 commented Mar 27, 2023 •

edited

Loading

jhp-lanl commented Mar 27, 2023

Yurlungur left a comment

Yurlungur commented Aug 8, 2023

dholladay00 commented Aug 16, 2023

dholladay00/separate get sg eos #245

dholladay00/separate get sg eos #245

Conversation

dholladay00 commented Mar 27, 2023 • edited Loading

PR Summary

PR Checklist

jhp-lanl commented Mar 27, 2023

Yurlungur left a comment

Choose a reason for hiding this comment

Yurlungur commented Aug 8, 2023

dholladay00 commented Aug 16, 2023

dholladay00 commented Mar 27, 2023 •

edited

Loading