Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix examples #238

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix examples #238

merged 2 commits into from
Mar 15, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Mar 6, 2023

PR Summary

The robust_tools caused a namespace collision with the examples. This fixes that issue by leveraging robust::ratio. I also ensure the examples are built in the tests to ensure the examples continue to compile.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur requested a review from rbberger March 6, 2023 22:17
@Yurlungur Yurlungur self-assigned this Mar 6, 2023
@Yurlungur Yurlungur linked an issue Mar 6, 2023 that may be closed by this pull request
@Yurlungur Yurlungur merged commit d4035f7 into main Mar 15, 2023
@Yurlungur Yurlungur deleted the jmm/fix-examples branch March 15, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples broken
3 participants