-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information to the contributing section especially laying out concerns for how to develop in singularity-eos and expectations for code review #209
Conversation
…ut concerns for how to develop in singularity-eos and expectations for code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Yurlungur for this addition! I think these are some really good points and I appreciate them being written down.
I think this is enough approvals. I'm going to merge it now. Thanks everyone for looking through this! |
If anyone looks at this after the fact and would like a change, please let me know. This should be a "living" document. |
PR Summary
I believe a recent code review caused some friction. As such I want to lay out in writing some best practices and expectations for contributing to
singularity-eos
. This includes:To be clear no one is at fault. However, I think having some expectations in writing that we can all point to and follow will help us interact more productively with each other going forward.
I'd like to reach out to the core team to ask for feedback on these expectations and then let's all try to follow them.
PR Checklist
make format
command after configuring withcmake
.