-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust hdf5, along with more refined I/O from cmake #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @jdolence can you double check this resolves the issues you were seeing?
@jdolence what is your timeline on testing this? I'd like to get this in soon. |
@mauneyc-LANL can you resolve all incomplete items in the checklist? When completed, I'll merge. I suspect downstream testing will be necessary. |
Yeah I think @jdolence is not going to test this. Assuming tests pass I'm fine with merging without waiting for him. |
@@ -285,22 +285,12 @@ if (SINGULARITY_USE_HDF5) | |||
enable_language(C) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauneyc-LANL We can drop this for cmake>=3.26, see: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes; Indeed, we don't require to do this for spiner
, and I'm working on a PR for singularity to follow that approach.
PR Summary
Addressing issues @jdolence encountered with HDF5 resolution. Some small rearranging of dependency logic, and a less chatty cmake (by default, can be adjusted)
I had attempted to use
module
mode to resolvefind_package(HDF5)
with a distributedFindHDF5.cmake
, but I think I made a mess of it and Josh hit an issue that arose from that. The large change here is to revert to a more "standard" approach that relies on the implementation of "official" Kitware CMake module (https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindHDF5.cmake).For reference, it can be informative to expose some trace information on
find_package
when configuringcmake --debug-find-pkg=HDF5 .. -DSINGULARITY_USE_HDF5=ON #...
Other notable changes:
--log-level=VERBOSE
option:cmake --log-level=VERBOSE .. #...
singularity_import_*
macros@jonahm-LANL @dholladay00 @jhp-lanl
PR Checklist
make format
command after configuring withcmake
.