Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to install fortran mod files #151

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Conversation

mauneyc-LANL
Copy link
Collaborator

@mauneyc-LANL mauneyc-LANL commented Jul 7, 2022

PR Summary

CMake was not properly installing fortran module files when invoking make install. These changes explicitly install the module files.

I'm working on a more robust solution than hand-copying the files, but otherwise this addresses the prior flaw.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file

@mauneyc-LANL mauneyc-LANL requested a review from Yurlungur July 7, 2022 22:50
@mauneyc-LANL mauneyc-LANL self-assigned this Jul 7, 2022
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some test for the fortran install so we know it works in the future?

@mauneyc-LANL
Copy link
Collaborator Author

Should we add some test for the fortran install so we know it works in the future?

No opinion; but would probably do it in a separate update

@Yurlungur Yurlungur merged commit ffda4d1 into main Jul 8, 2022
@Yurlungur Yurlungur deleted the mauneyc/fix/install_modfile branch July 8, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants