Proposed changes to #541 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-T-McCann
approved these changes
Jul 19, 2024
bwohlberg
added a commit
that referenced
this pull request
Jul 24, 2024
* Change np random generation to jax np * Bump supported jaxlib/jax versions * Avoid doctest errors resulting from unimportable astra or svmbir * Avoid doctest failure due to changes in numpy 2.0 * Address FutureWarning in 2D x-ray * Update submodule * Proposed changes to #541 (#543) * Add type annotation * Remove jax distributed data generation option * Clean up * Extend docs * Add additional test for exception state * Tracer conversion error fix from Cristina * Omitted import * Clean up * Consistent phrasing * Clean up some f-strings * Add missing ray init * Set dtype * Fix indentation error * Update module docstring * Experimental solution to ray/jax failure * Bug fix * Improve docstring * Implement hack to resolve jax/ray conflict * Debug attempt * New solution attempt * Debug attempt * Return to earlier approach * Extend comment * Clean up and improve function logic * Address some problems * Clean up * Rename function for consistency with related functions * Bug fix * Clean up * Bug fix * Address pylint complaint * Revert unworkable structure * Error message fix * Address mypy errors --------- Co-authored-by: Brendt Wohlberg <[email protected]> Co-authored-by: Michael-T-McCann <[email protected]> Co-authored-by: Brendt Wohlberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes to #541: