Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #445 #459

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Resolve #445 #459

merged 9 commits into from
Oct 24, 2023

Conversation

bwohlberg
Copy link
Collaborator

Resolve #445.

@bwohlberg bwohlberg added the bug Something isn't working label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #459 (07e0bbe) into main (216ffc8) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   93.34%   93.33%   -0.02%     
==========================================
  Files          87       87              
  Lines        5512     5514       +2     
==========================================
+ Hits         5145     5146       +1     
- Misses        367      368       +1
Flag Coverage Δ
unittests 93.33% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scico/numpy/util.py 97.70% <100.00%> (+0.05%) ⬆️
scico/operator/_operator.py 94.92% <100.00%> (ø)

... and 1 file with indirect coverage changes

Michael-T-McCann
Michael-T-McCann requested changes Oct 16, 2023
View reviewed changes
scico/operator/_operator.py Show resolved Hide resolved
scico/operator/_operator.py Outdated Show resolved Hide resolved
scico/operator/_operator.py Outdated Show resolved Hide resolved
Michael-T-McCann
Michael-T-McCann reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple suggestions

@bwohlberg
Copy link
Collaborator Author

couple suggestions

Done.

@bwohlberg bwohlberg merged commit ea2aaf0 into main Oct 24, 2023
17 checks passed
@bwohlberg bwohlberg deleted the brendt/issue442 branch October 24, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-T-McCann Michael-T-McCann Michael-T-McCann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linear operator multiplication with singleton array not supported
2 participants
@bwohlberg @Michael-T-McCann