Rename linear problem solver and add parameter type checking #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwohlberg
added
the
improvement
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 93.34% 93.26% -0.08%
==========================================
Files 87 87
Lines 5514 5522 +8
==========================================
+ Hits 5147 5150 +3
- Misses 367 372 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scico/solver.py
Outdated
| raise ValueError("If matrix, D should be 1D or 2D.") | ||
| raise ValueError("If MatrixOperator, D should be 1D or 2D.") |
There was a problem hiding this comment.
This error can be raised by either an array or a MatrixOperator, maybe should be "If array or MatrixOperator..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename linear problem solver and add parameter type checking.