Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Update #62

Merged
merged 5 commits into from
Nov 15, 2024
Merged

CI Update #62

merged 5 commits into from
Nov 15, 2024

Conversation

rbberger
Copy link
Collaborator

PR Summary

  • Upgrades common CI parts, adds ATS2 builds
  • Adds reporting to LANL internal CDash
  • Fixes some CMake issues

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@rbberger rbberger force-pushed the rberger/ci_update branch 3 times, most recently from 3aaa4ff to 62e1998 Compare November 14, 2024 21:31
@Yurlungur
Copy link
Collaborator

@rbberger since the cmake seems to be failing I assume this is WIP?

Yurlungur
Yurlungur approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

.gitlab-ci.yml
@@ -4,16 +4,36 @@ stages:

variables:
PROJECT_NAME: ports-of-call
ENABLE_CDASH: false
ENABLE_CDASH: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting

@Yurlungur
Copy link
Collaborator

@rbberger since the cmake seems to be failing I assume this is WIP?

ah nevermind. I see you fixed it.

@Yurlungur Yurlungur self-assigned this Nov 14, 2024
@Yurlungur
Copy link
Collaborator

Let me know when you're ready to merge.

@rbberger
Copy link
Collaborator Author

@Yurlungur This is ready.

@Yurlungur Yurlungur merged commit 0db70bf into main Nov 15, 2024
4 checks passed
@Yurlungur Yurlungur deleted the rberger/ci_update branch November 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees

@Yurlungur Yurlungur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbberger @Yurlungur