-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer span from Singe #47
Conversation
0c37f80
to
ca5e117
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few changes and/or points of discussion.
In general, I'm okay with this as a placeholder awaiting the move to C++20. If it's of interest, I have some code with a more "compliant" span
(the code is unfinished, but span
is finished).
There is an general question with the introduction of span
; the next obvious step is mdspan
, but this would basically supersede PortableMDArray
(and, in my opinion, this should happen). Is this the goal?
|
I would be supportive of a portable backport of
This is not the current goal. I'm open to this path, but for backwards compatibility reasons would prefer I think the only things that currently use All that said: our priority is not cleaning up the old code in In the long term, I'm supportive of replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at this point. @mauneyc-LANL please re-review.
4af547c
to
0c74114
Compare
I'm closing this as it is superseded by #60. |
PR Summary
An implementation of
std::span
that works on both the CPU and the GPU.PR Checklist