Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable C++17 #45

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Enable C++17 #45

merged 1 commit into from
Aug 15, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

What it says on the can. It's finally time @mauneyc-LANL

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur self-assigned this Aug 15, 2024
@Yurlungur
Copy link
Collaborator Author

@dholladay00 @mauneyc-LANL @jhp-lanl @rbberger one person please review.

@Yurlungur Yurlungur requested a review from chadmeyer August 15, 2024 14:59
@Yurlungur Yurlungur merged commit 8085045 into main Aug 15, 2024
3 checks passed
@Yurlungur Yurlungur deleted the jmm/cxx17 branch August 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholladay00 dholladay00 dholladay00 approved these changes

@mauneyc-LANL mauneyc-LANL Awaiting requested review from mauneyc-LANL

@jhp-lanl jhp-lanl Awaiting requested review from jhp-lanl

@chadmeyer chadmeyer Awaiting requested review from chadmeyer

Assignees

@Yurlungur Yurlungur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurlungur @dholladay00 @jonahm-LANL