-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First cut at adding printf, help builds. #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good add. Doesn't look like it's all working yet?
This works sufficiently for our purposes as this change-set gets The other question @Yurlungur is should be remove this from impl namespace and put it in a public facing namespace? I think yes as downstream codes will likely want this thing if they want to build with hip. |
Broadly, I concur:
No---let's wait until that's just the version we depend on. We can do what you did here until then,
Yes, let's put it in the public namespace. |
@dholladay00 let me know when this is ready for review/merge |
…nces until newer versions are common.
@Yurlungur are there additional tests on Darwin that I can run or is this sufficient? This is ready to go pending necessary testing if not already accomplished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go
PR Summary
This adds an internal print function used by portable errors machinery that stubs out printf on hip where printf doesn't exist.
@Yurlungur @mauneyc-LANL @rbberger @chadmeyer
PR Checklist