Simplifying pydfnworks installation process #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename pydfnworks/pydfnworks to pydfnworks - update docs
- add Makefile to build all binaries - add setup.py to build binaries when call pip install - remove unnecessary environment variables of dfnworks in source code - update docs
|
@ongchi Thank you for the PR submission, but the scope of this PR is too expansive to be accepted as a single PR. There are modifications to both the pydfnworks procedure and DFNTrans. Note that DFNTrans is no longer being developed / maintained as we expect a release of dfnTrans2.0 in the coming year. |
|
Thank you for your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #77
This PR simplify the installation process of pydfnworks: