Add pre-commit hook script #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbock
requested review from
cnegre,
suemni,
jeanlucf22,
tokshgithub and
jmohdyusof
as code owners
nicolasbock
force-pushed
the
hooks
branch
2 times, most recently
from
6398814 to
cc36cca
Compare
suemni
approved these changes
Jun 3, 2022
The pre-commit hook script needs to be copied locally to: $ cp scripts/pre-commit .git/hooks/pre-commit It will run the linter before committing. Since the linter takes a while to complete, it can be helpful to disable this check if desired. Adding the `--no-verify` command line option to `git commit` will do that: $ git commit --no-verify [options] Note that for reasons of reproducibility the linter runs inside a docker container. Therefore, the only pre-requisite for the hook is docker. Signed-off-by: Nicolas Bock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-commit hook script needs to be copied locally to:
$ cp scripts/pre-commit .git/hooks/pre-commit
It will run the linter before committing.
Since the linter takes a while to complete, it can be helpful to disable
this check if desired. Adding the
--no-verifycommand line option togit commitwill do that:$ git commit --no-verify [options]
Signed-off-by: Nicolas Bock [email protected]