Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTD badge #575

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Add RTD badge #575

merged 1 commit into from
Jan 26, 2022

Conversation

nicolasbock
Copy link
Collaborator

Signed-off-by: Nicolas Bock [email protected]

Signed-off-by: Nicolas Bock <[email protected]>
@jmohdyusof
Copy link
Collaborator

Doesn't it make sense to change the docs branch to be the default for RTD for now, so that you don't have to merge with master every time?

@nicolasbock
Copy link
Collaborator Author

RTD is building from master. Currently we don't have a separate docs branch.

I would prefer if we left the documentation in the master branch so that we don't have to sync branches to keep the documentation up to date.

@nicolasbock
Copy link
Collaborator Author

@jmohdyusof It turns out that RTD is using a really old sphinx version (sphinx-1.8.6) which I didn't catch when testing the documentation build locally. I have submitted #576 to address this.

@nicolasbock nicolasbock merged commit 5cd684a into lanl:master Jan 26, 2022
@nicolasbock nicolasbock deleted the rtd_badge branch January 26, 2022 17:10
@jmohdyusof
Copy link
Collaborator

RTD is building from master. Currently we don't have a separate docs branch.

I would prefer if we left the documentation in the master branch so that we don't have to sync branches to keep the documentation up to date.

I was suggesting to make a docs branch and set RTD to use that temporarily so that you (and I?) can edit it on the fly to make docs work, then we can merge to master and set RTD to use master going forward. Otherwise every edit requires a pull request.

@nicolasbock
Copy link
Collaborator Author

Ok I see. I created a docs branch and set RTD to build from it.

@jmohdyusof
Copy link
Collaborator

Cool, let me know if you want me to help with hacking on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants