Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #163

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Develop #163

merged 11 commits into from
Apr 29, 2024

Conversation

MaksimEkin
Copy link
Member

@MaksimEkin MaksimEkin commented Apr 29, 2024

  • Fixes a bug where Ks were not organized correctly for BST post and pre order.
  • Fixes a bug for H_sill_thresh, now allowing for being able to set threshold at negative values as well.
  • Adds option to use either W sill for k prediction, H sill for k prediction, or both. Selection of the predict_k_method also changes how the BST search is done with k_search_method. Below hyper-parameters for NMFk are modified accordingly:

predict_k_method : str, optional
Method to use when performing automatic k prediction. Default is "WH_sill".

predict_k_method='pvalue' # will use L-Statistics with column-wise error for automatically estimating the number of latent factors.
predict_k_method='WH_sill' # will use Silhouette scores from minimum of W and H latent factors for estimating the number of latent factors.
predict_k_method='W_sill' # will use Silhouette scores from W latent factor for estimating the number of latent factors.
predict_k_method='H_sill' # will use Silhouette scores from H latent factor for estimating the number of latent factors.
predict_k_method='sill' # will default to ``predict_k_method='WH_sill'``.

@MaksimEkin MaksimEkin self-assigned this Apr 29, 2024
@MaksimEkin MaksimEkin requested review from SoloNick and ryancb4 April 29, 2024 19:56
@MaksimEkin MaksimEkin marked this pull request as draft April 29, 2024 19:56
@MaksimEkin MaksimEkin linked an issue Apr 29, 2024 that may be closed by this pull request
@MaksimEkin MaksimEkin marked this pull request as ready for review April 29, 2024 23:42
@MaksimEkin MaksimEkin merged commit a0b2be7 into main Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant