Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC CLI builds as run by the regression system. #912

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Sep 21, 2020

Background

  • After upgrading to Microsoft Visual Studio 2019 16.8.0 Preview 3, the regression system could no longer build Draco due to build errors reported in system headers pulled in by rng/test. This version of MSVC also pulls in a newer version of CMake.

Purpose of Pull Request

Description of changes

  • It was determined that these build errors could be eliminated by registering the rng unit tests as C++ files instead of C files, even though their file extensions are .c.
  • Also add a couple of new warning suppressions for MSVC. The new version is more aggressive in reporting warnings. Only suppress issues found in the Random123 header files (we don't need to fix the TPL code).
  • It was also found that the test ut_gsl provided by Random123 has a defect to most compilers are happy to ignore, but that MSVC now treats as a fatal error (a variable is declared twice in the same scope). See rng/tests/CMakeLists.txt for more details.

Status

+ After upgrading to Microsoft Visual Studio 2019 16.8.0 Preview 3, the
  regression system could no longer build Draco due to build errors reported in
  system headers pulled in by `rng/test`.  This version of MSVC also pulls in
  a newer version of CMake.
+ It was determined that these build errors could be eliminated by registering
  the rng unit tests as C++ files instead of C files, even though their file
  extensions are `.c`.
+ Also add a couple of new warning suppressions for MSVC.  The new version is
  more agressive in reporting warnings.  Only suppress issues found in the
  Random123 header files (we don't need to fix the TPL code).
@KineticTheory KineticTheory added this to the Draco-7_8_0 milestone Sep 21, 2020
@KineticTheory KineticTheory self-assigned this Sep 21, 2020
@KineticTheory
Copy link
Collaborator Author

I'm breaking my own rules again. I'm going to merge this w/o additional review. The changes are primarily targeting the MSVC build system.

@KineticTheory KineticTheory merged commit f8ea72a into develop Sep 22, 2020
@KineticTheory KineticTheory deleted the fix_msvc_cli_regression branch September 22, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant