-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating cshrc for toss22 #84
Conversation
massimilianorosa
commented
Oct 13, 2016
•
edited
Loading
edited
- Purpose of Pull Request
- Update cshrc file for toss22 machines, refs Fix size mismatch in ofpstream #821 (redmine number)
- DRACO_AUTO_CLANG_FORMAT variable gets also set to ON
- Fixes Fix size mismatch in ofpstream #821 (redmine number)
- Pre-Merge Code Review
- Travis CI checks pass
- Code coverage does not decrease
- Valgrind test passes
- Toss2 checks pass
- Trinitite checks pass
- Code reviewed/approved, sufficient DbC checks, testing, documentation
…minated POLYH0_8 which was superseded by POLYHEDRON.
@massimilianorosa Please update the description text to describe your pull request. |
Current coverage is 85.30% (diff: 100%)@@ develop #84 diff @@
==========================================
Files 350 350
Lines 15893 15893
Methods 2145 2145
Messages 0 0
Branches 2146 2146
==========================================
+ Hits 13556 13558 +2
Misses 1574 1574
+ Partials 763 761 -2
|
@massimilianorosa There is something wrong with this github pull request. There are 5 commits and the log files refer to POLYH0_8 changes. Those should not be included in this PR. I am going to reject the PR and have you submit a new one. Please start with a clean clone of draco, switch to a feature branch before changing any code (never work on the ‘develop’ branch) and push that feature branch back to github. Please follow the directions at https://rtt.lanl.gov/redmine/projects/draco/wiki/Draco_on_GitHub. Your workflow should look like this:
|
@massimilianorosa @KineticTheory |