Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cshrc for toss22 #84

Closed
wants to merge 5 commits into from

Conversation

massimilianorosa
Copy link

@massimilianorosa massimilianorosa commented Oct 13, 2016

@KineticTheory
Copy link
Collaborator

@massimilianorosa Please update the description text to describe your pull request.

@codecov-io
Copy link

codecov-io commented Oct 13, 2016

Current coverage is 85.30% (diff: 100%)

Merging #84 into develop will increase coverage by 0.01%

@@            develop        #84   diff @@
==========================================
  Files           350        350          
  Lines         15893      15893          
  Methods        2145       2145          
  Messages          0          0          
  Branches       2146       2146          
==========================================
+ Hits          13556      13558     +2   
  Misses         1574       1574          
+ Partials        763        761     -2   

Powered by Codecov. Last update 5952c34...39906e3

@KineticTheory
Copy link
Collaborator

@massimilianorosa There is something wrong with this github pull request. There are 5 commits and the log files refer to POLYH0_8 changes. Those should not be included in this PR. I am going to reject the PR and have you submit a new one. Please start with a clean clone of draco, switch to a feature branch before changing any code (never work on the ‘develop’ branch) and push that feature branch back to github. Please follow the directions at https://rtt.lanl.gov/redmine/projects/draco/wiki/Draco_on_GitHub.

Your workflow should look like this:

  1. git clone [email protected]:massimilianorosa/Draco.git draco
  2. cd draco; git remote add upstream [email protected]:losalamos/Draco.git
  3. git checkout –b update-cshrc # update-cshrc is the name of the feature-branch (pick any descriptive name)
  4. make changes to .cshrc file
  5. git commit (include the text ‘fixes Fix size mismatch in ofpstream #821’ in your commit message. this will automatically close the redmine ticket).
  6. git push
  7. Visit github.com/losalamos/Draco and create a pull request.
  8. The PR should include 1 file and only show changes directly related to the PR.
  9. Provide a description of the change. If there is more work to be done prefix the subject with WIP.
  10. Let someone else inspect and comment on your changes

@warsa
Copy link
Contributor

warsa commented Oct 13, 2016

@massimilianorosa @KineticTheory
Is this to REMOVE a POLYH0_8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants