Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Updated mdspan #814

Closed
wants to merge 2 commits into from
Closed

WIP: Updated mdspan #814

wants to merge 2 commits into from

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Apr 28, 2020 •
edited
Loading

Background

Purpose of Pull Request

Description of changes

Update 2020-09-07

       "C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj" (default target) (120) ->
       (ClCompile target) -> 
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(64,1): error C2371: 'std::is_assignable_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(65,1): error C2371: 'std::is_constructible_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(66,1): error C2371: 'std::is_convertible_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(67,1): error C2371: 'std::is_default_constructible_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(68,1): error C2371: 'std::is_trivially_destructible_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(69,1): error C2371: 'std::is_same_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(70,1): error C2371: 'std::is_empty_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]
         C:\projects\draco\src\experimental\__p0009_bits\trait_backports.hpp(71,1): error C2371: 'std::is_void_v': redefinition; different basic types [C:\projects\build\src\experimental\test\Ut_experimental_tst_mdspan_exe.vcxproj]

Status

@KineticTheory
Update mdspan
756f69a 
* New mdspan hash 0f076223d1b36690323e8410f4a82a7716b84875
  (github.com/kokkos/mdspan).
* Provide custom `.clang-format` to avoid reformatting external code.
* Rename original `mdspan` to `kokkos_mdspan` and create a new wrapper file
  `mdspan` that provides appropriate compiler warning suppressions.
* Update the `LICENSE.md` file with the new hash information.
* This version of mdspan provides many bug fixes and should now work with
  intel-17.0.4, in addition to gcc, clang, and msvc compilers.
@KineticTheory KineticTheory added this to the Draco-7_7_0 milestone Apr 28, 2020
@KineticTheory KineticTheory self-assigned this Apr 28, 2020
@KineticTheory KineticTheory mentioned this pull request Apr 28, 2020
Closed
8 tasks
@KineticTheory KineticTheory mentioned this pull request Apr 29, 2020
Open
@KineticTheory KineticTheory mentioned this pull request Sep 7, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KineticTheory KineticTheory

Labels
bug
Projects
None yet
Milestone
Draco-7_9_0
Development

Successfully merging this pull request may close these issues.

Update mdspan to match upstream
1 participant
@KineticTheory