WIP: Flatten pr 697 into one changeset. #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add some debug output to `CMakeAddFortranSubdirectory`. This should only be active if the local macro variable `verbose` is `true`. + Update `print_target_properties` to print target values related to file LOCATIONS. + Update how MPI is discovered for VS2019 builds that provide msmpi via vcpkg. Also add some debug prints that can optionally be enabled. Tested with MS-MPI 10.0. + Update `vendor_libraries` to correctly create imported targets for openblas for VS2019. openblas can be installed via vcpkg. + The f90sub Fortran package is built via CAFS under VS2019 (with MSYS2 MinGW's gfortran). Newer CMake (3.16.1) and MS-MPI (10.0) behave a little different that the older versions and extra logic was needed to correctly point to the MPI libraries. (Also, start using a target property to ensure the generated library is installed in the correct location.) + When TPLs are provided by vcpkg, we use a `CMAKE_TOOLCHAIN_FILE`. Ensure that this information is passed to the CAFS sub-project. + Remove unnecessary DLL_PUBLIC decoration from `fc_derivided_type.cc`. + Remove double underscores from CPP names in lapack_wrap. + Update the `quadrature/CMakeLists.txt` portions related to CAFS so they match the commands used in `FortranChecks`.
6 tasks
+ Also remove duplicate linear_interpolate_3 function.
+ In `CMakeAddFortranSubdirectory.cmake`, only munge MPI settings if
`DRACO_C4=MPI`.
+ In `windows-cl.cmake`:
- Use `CMAKE_SIZEOF_VOID_P` instead of `CMAKE_CL_64` as recommended by CMake.
- Make searching for `ws2_32.lib` more robust by searching in more locations
and exiting the seearch loop once found.
+ In `FortranChecks/test/CMakeLists.txt`, make the search for
`libquadmath-0.dll` more robust.
+ Fix some comparisons between signed and unsigned integral values in
`RTT_Format_Reader` and in `mdpsan`'s implementation.
+ Suppress a warning about unreachable code in `C4_Serial.cc`.
|
This is no longer needed now that #725 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
developand squashed into one commit.Purpose of Pull Request
Description of changes
Status