Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return uint32_t instead of int. #708

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Return uint32_t instead of int. #708

merged 1 commit into from
Jan 2, 2020

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Dec 11, 2019 •
edited by brryan
Loading

Background

  • gcc on snow is reporting signed/unsigned comparison warnings.

Description of changes

  • Modify return types from QueryEnv.hh to fix warnings.

Status

@KineticTheory KineticTheory force-pushed the fix_queryenv_unsigned branch from bc7faf1 to 9115e62 Compare January 2, 2020 22:15
@KineticTheory KineticTheory self-assigned this Jan 2, 2020
@KineticTheory KineticTheory added this to the Draco-7_5_0 milestone Jan 2, 2020
@KineticTheory KineticTheory changed the title WIP: Return uint32_t instead of int. Return uint32_t instead of int. Jan 2, 2020
@KineticTheory KineticTheory requested a review from brryan January 2, 2020 23:28
@KineticTheory
Copy link
Collaborator Author

@brryan All tests pass. I think this PR is ready for final review and merge.

brryan
brryan approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brryan brryan merged commit 2517224 into lanl:develop Jan 2, 2020
@KineticTheory KineticTheory deleted the fix_queryenv_unsigned branch January 3, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brryan brryan brryan approved these changes

Assignees

@KineticTheory KineticTheory

Labels
bug ready
Projects
None yet
Milestone
Draco-7_5_0
Development

Successfully merging this pull request may close these issues.
2 participants
@KineticTheory @brryan