Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in CMake CUDA flags and set the NVCC language level to 14 #604

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

alexrlongne
Copy link
Contributor

@alexrlongne alexrlongne commented Apr 16, 2019

Background

  • I didn't fully test some of the CMake for the new CUDA specific device code and I had a few syntax errors in CMake. This pull request corrects those errors and adds a language level to the nvcccompiler, set through theCMAKE_CUDA_STANDARD` variable.

Purpose of Pull Request

  • Fixes bug in CUDA specific CMake code

Description of changes

  • Fix set statements that were not terminated properly
  • Add FORCE to the set statement for CMAKE_CUDA_FLAGS
  • Set the CMAKE_CUDA_STANDARD to 14

Status

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #604 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #604   +/-   ##
=======================================
  Coverage     93.7%   93.7%           
=======================================
  Files          381     381           
  Lines        17805   17805           
=======================================
  Hits         16687   16687           
  Misses        1118    1118

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #604 into develop will increase coverage by 1.6%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop    #604     +/-   ##
=========================================
+ Coverage       92%   93.7%   +1.6%     
=========================================
  Files          368     381     +13     
  Lines        17073   17805    +732     
=========================================
+ Hits         15714   16687    +973     
+ Misses        1359    1118    -241

config/vendor_libraries.cmake Outdated Show resolved Hide resolved
@KineticTheory KineticTheory merged commit 584aa5d into lanl:develop Apr 17, 2019
@KineticTheory KineticTheory mentioned this pull request Jun 17, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants