Updates to the regression system to support TRT and NPT #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Many changes to scripts to improve how file and directory permissions are established. The biggest change is to try and set the group sticky bit (GID) for newly created directories. + Remove references to capsaicin by replacing them with core, npt or trt. + Update `checkpr.sh` to teach it about trt and npt dependencies. In particular, trt-vtest regression runs will link to non-vtest versions of core. While, this logic should probably be generalized and moved into core, I didn't want to make those changes right now out of fear of creating too much new work associated with standing up regression and CI testing for trt and npt. + Simplify some of the logic in `draco_regression_macros.cmake` when trt or npt are looking for a core or draco installation.
Codecov Report
@@ Coverage Diff @@
## develop #565 +/- ##
=======================================
Coverage 93.3% 93.3%
=======================================
Files 377 377
Lines 17676 17676
=======================================
Hits 16496 16496
Misses 1180 1180 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #565 +/- ##
=======================================
Coverage 93.3% 93.3%
=======================================
Files 377 377
Lines 17676 17676
=======================================
Hits 16496 16496
Misses 1180 1180 |
|
@jhchang-lanl has reviewed and approved this PR. I'm merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Purpose of Pull Request
Description of changes
checkpr.shto teach it about trt and npt dependencies. In particular, trt-vtest regression runs will link to non-vtest versions of core. While, this logic should probably be generalized and moved into core, I didn't want to make those changes right now out of fear of creating too much new work associated with standing up regression and CI testing for trt and npt.draco_regression_macros.cmakewhen trt or npt are looking for a core or draco installation.Status