Fix GSL discovery. #483
Merged
Fix GSL discovery. #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Newer GSL installs on Windows provide `gsl-config.cmake` that should be
used to create the GSL import targets instead of attempting to use the
CMake Module mode, `FindGSL.cmake`, method of finding GSL.
+ Change the order in which we call various GSL-discovery modes.
1. Try CMake's `CONFIG` mode (looks for `gsl-config.cmake` in `
CMAKE_PREFIX_PATH`).
2. Try to find `gsl-config.sh` (Linux's package-config mode) and use
this script to identify `GSL_ROOT_DIR` before calling (3).
3. Try CMake's `FindGSL.cmake` (`MODULE` mode).
Codecov Report
@@ Coverage Diff @@
## develop #483 +/- ##
=======================================
Coverage 91.9% 91.9%
=======================================
Files 375 375
Lines 17483 17483
=======================================
Hits 16072 16072
Misses 1411 1411 |
|
@RyanWollaeger All tests pass. This can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
gsl-config.cmakethat should be used to create the GSL import targets instead of attempting to use the CMake Module mode,FindGSL.cmake, method of finding GSL.Description of changes
CONFIGmode (looks forgsl-config.cmakeinCMAKE_PREFIX_PATH).gsl-config.sh(Linux's package-config mode) and use this script to identifyGSL_ROOT_DIRbefore calling (3).FindGSL.cmake(MODULEmode).Status