Extend rtt_viz::Ensight_Translator's ensight_dump function. #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Allow the `ensight_dump` function to accept `vector<unsigned>` containers in addition to `vector<int>`. This required a little bit of cleanup in the function to keep all of the data types compatible. + Add a unit test for the new `ensight_dump` signature.
Codecov Report
@@ Coverage Diff @@
## develop #478 +/- ##
=======================================
Coverage 91.8% 91.8%
=======================================
Files 375 375
Lines 17472 17472
=======================================
Hits 16045 16045
Misses 1427 1427 |
|
@clevelam All testing passes. This is ready for final review and merge. This blocks my new PR for McGrid. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Description of changes
ensight_dumpfunction to acceptvector<unsigned>containers in addition tovector<int>. This required a little bit of cleanup in the function to keep all of the data types compatible.ensight_dumpsignature.Status