Safe a call to sqrt by wrapping its argument in fabs. #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quantities wrapped in fabs in the timer output code are formally positive indefinite, but roundoff error will sometimes make them very slightly negative. Wrappiong in fabs is a perfectly adequate fix, since the result printed will be zero, which is the right printed value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variances whose sqrt are taken in the timer output code are formally positive indefinite, but roundof will sometimes make them very slightly negative and trigger a floating point exception. Wrapping in fabs is a perfectly adequate fix, since the result printed will be zero, which is the right printed value.
Status