Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MPI operations for Bool variables #240

Merged
merged 4 commits into from
Jun 19, 2017
Merged

Conversation

clevelam
Copy link
Collaborator

@clevelam clevelam commented Jun 19, 2017

@codecov
Copy link

codecov bot commented Jun 19, 2017

Codecov Report

Merging #240 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
+ Coverage    84.27%   84.28%   +<.01%     
===========================================
  Files          344      344              
  Lines        15636    15637       +1     
  Branches      2092     2092              
===========================================
+ Hits         13178    13179       +1     
  Misses        1556     1556              
  Partials       902      902

@clevelam clevelam changed the title WIP: Added MPI operations for Bool variables Added MPI operations for Bool variables Jun 19, 2017
@KineticTheory KineticTheory self-requested a review June 19, 2017 20:55
@KineticTheory
Copy link
Collaborator

KineticTheory commented Jun 19, 2017

@clevelam Please update the PR description by removing the boilerplate text and providing some context (e.g.: why is this needed). Everything else looks fine.

@KineticTheory
Copy link
Collaborator

Note: Moonlight and Trinitite are not available for CI testing.

Copy link
Collaborator

@KineticTheory KineticTheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KineticTheory KineticTheory merged commit f77e757 into lanl:develop Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants