Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding parser check to ensure even azimuthal order #174

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Adding parser check to ensure even azimuthal order #174

merged 1 commit into from
Mar 8, 2017

Conversation

attom
Copy link
Contributor

@attom attom commented Mar 6, 2017 •
edited
Loading

Quadratures with an odd number of azimuthal angles should cause a parser error.
Previously, error only occurred in DBC check, which is often turned off in
release.

@attom
Adding parser check to ensure even azimuthal order
811fd07 
Quadratures with an odd number of azimuthal angles should cause a parser error.
Previously, error only occured in DBC check, which is often turned off in
release.
@KineticTheory KineticTheory self-requested a review March 7, 2017 03:30
@KineticTheory KineticTheory added this to the Draco-6_21_0 milestone Mar 7, 2017
@KineticTheory
Copy link
Collaborator

KineticTheory commented Mar 7, 2017 •
edited
Loading

@attom (nitpick) Please update the PR description to either remove the boiler plate text that provides links to Redmine issues OR update that block with actual bug report numbers from Redmine.

@KineticTheory
Copy link
Collaborator

@jhchang-lanl Please review this one-line change. Is the proposed code the normal way of dealing with invalid parser input?

jhchang-lanl
jhchang-lanl approved these changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@jhchang-lanl jhchang-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine.

@attom
Copy link
Contributor Author

attom commented Mar 8, 2017

Updated PR description.

KineticTheory
KineticTheory approved these changes Mar 8, 2017
View reviewed changes
Copy link
Collaborator

@KineticTheory KineticTheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KineticTheory KineticTheory merged commit 2b001c6 into lanl:develop Mar 8, 2017
@attom attom deleted the quadrature_dbc branch March 8, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhchang-lanl jhchang-lanl jhchang-lanl approved these changes

@KineticTheory KineticTheory KineticTheory approved these changes

Assignees

@attom attom

Labels
bug
Projects
None yet
Milestone
Draco-6_21_0
Development

Successfully merging this pull request may close these issues.
3 participants
@attom @KineticTheory @jhchang-lanl