Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide git-hook that updates copyright block automagically. #1105

Merged
merged 7 commits into from
Aug 12, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Aug 11, 2021

Background

Description of changes

  • For modified files, ensure that the copyright dates/text are correct.
    • Inspect file types: .c .cc .cmake .h .hh .in .f90 .F90 .f .F .py .txt
  • To do: Provide a sanity check in check_style.sh for devs who don't use our pre-commit hooks.

Status

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1105 (53664ae) into develop (f23bf69) will not change coverage.
The diff coverage is n/a.

❗ Current head 53664ae differs from pull request most recent head ba7c409. Consider uploading reports for the commit ba7c409 to get more accurate results

@@           Coverage Diff           @@
##           develop   #1105   +/-   ##
=======================================
  Coverage     88.7%   88.7%           
=======================================
  Files          374     374           
  Lines        18593   18593           
=======================================
  Hits         16497   16497           
  Misses        2096    2096           

@KineticTheory KineticTheory self-assigned this Aug 12, 2021
@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Aug 12, 2021
@KineticTheory KineticTheory changed the title WIP: Provide git-hook that updates copyright block automagically. Provide git-hook that updates copyright block automagically. Aug 12, 2021
KineticTheory added a commit to KineticTheory/Draco that referenced this pull request Aug 12, 2021
+ Extend the capabilities of `opstream` by allowing output to be directed to any `std::ostream`
  instead of forcing output to `std::cout`. If the output stream is not specified, it will default
  to the previous behavior of `std::cout`.
+ Provide `const` attribute for some arguments of functions provided in `dbc.hh`.
+ This PR also serves as a sanity check for the new git pre-commit-copyright hook, lanl#1105.
@KineticTheory KineticTheory merged commit b430098 into lanl:develop Aug 12, 2021
keadyk pushed a commit that referenced this pull request Aug 13, 2021
* Enhance opstream by allowing output to a specified buffer.

+ Extend the capabilities of `opstream` by allowing output to be directed to any `std::ostream`
  instead of forcing output to `std::cout`. If the output stream is not specified, it will default
  to the previous behavior of `std::cout`.
+ Provide `const` attribute for some arguments of functions provided in `dbc.hh`.
+ This PR also serves as a sanity check for the new git pre-commit-copyright hook, #1105.

* Fix doxygen error.

* rename variable to avoid shadowing.

* Fix mismatched const in hh and i.hh file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant