Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vor2d mesh faces fix #1103

Merged
merged 13 commits into from
Aug 11, 2021
Merged

Vor2d mesh faces fix #1103

merged 13 commits into from
Aug 11, 2021

Conversation

brryan
Copy link
Contributor

@brryan brryan commented Aug 10, 2021

Background

  • The recently added python 2D voronoi generator was not outputting some variables correctly
  • It's difficult to debug computational geometry without visualizing it

Purpose of Pull Request

Description of changes

  • Fix bugs in vor_2d_mesh mesh type with faces that share nodes and boundary data
  • Add x3d_plotter.py script that quickly plots 2D x3d mesh files

Status

@brryan brryan requested a review from RyanWollaeger August 10, 2021 17:22
@brryan brryan self-assigned this Aug 10, 2021
@brryan
Copy link
Contributor Author

brryan commented Aug 10, 2021

@KineticTheory were there other details you wanted added to the README? I'm happy to add to it

Copy link
Contributor

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few questions.

src/mesh/python/mesh_types.py Show resolved Hide resolved
src/mesh/python/mesh_types.py Show resolved Hide resolved
src/mesh/python/mesh_types.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1103 (5fe33f3) into develop (a659254) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1103   +/-   ##
=======================================
  Coverage     88.7%   88.7%           
=======================================
  Files          374     374           
  Lines        18593   18593           
=======================================
  Hits         16497   16497           
  Misses        2096    2096           

@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Aug 11, 2021
@KineticTheory KineticTheory merged commit 20093fd into lanl:develop Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants