Add logic for setting DRACO_ROUNDOFF_MODE for FMA CPP macro. #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add build system logic that allows us to toggle between *fast* and *accurate* FMA modes. In general, *accurate* is required for CI and regression testing while *fast* is enabled for releases. + Related to lanl#6 + Added a new CMake option `DRACO_ROUNDOFF_MODE` that defaults to `ACCURATE`. + This option is published in `draco-config.cmake` and `ds++/config.h` so other projects are aware of Draco's run mode for FMA. The cmake file provide information to client build systems. The header file provides information to client source code. + Release scripts were updated so that *fast* FMA is enabled for releases.
+ The `cmake-format` program damaged some text blocks that needed manual cleaning up. + Update the new PR templte so that it points to re-git instead of redmine.
alexrlongne
approved these changes
Jul 28, 2021
|
Looks good, it didn't look like there were any non-format changes to the |
KineticTheory
commented
Jul 28, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1093 +/- ##
=======================================
Coverage 88.7% 88.7%
=======================================
Files 374 374
Lines 18592 18592
=======================================
Hits 16496 16496
Misses 2096 2096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Purpose of Pull Request
Description of changes
DRACO_ROUNDOFF_MODEthat defaults toACCURATE.draco-config.cmakeandds++/config.hso other projects are aware of Draco's run mode for FMA. The cmake file provide information to client build systems. The header file provides information to client source code.cmake-formatstyle fixes.Status