-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D orthogonal structure mesh type for mesh generators. #1091
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1091 +/- ##
=======================================
Coverage 88.7% 88.7%
=======================================
Files 374 374
Lines 18591 18592 +1
=======================================
+ Hits 16495 16496 +1
Misses 2096 2096 |
Sorry - forgot to run flake8 on this before submitting - will do so shortly. |
+ Add orth_3d_mesh class to mesh_types.py. + Add orth_3d_mesh as an option to x3d_generator.py. + Test 1-cell result of orth_3d_mesh in X3D parser unit test.
4c6774e
to
e4c2cc2
Compare
I should probably add a comment on how to use the x3d_generator script, e.g.:
|
Can you add this to a |
Good idea - will do! |
The markup linter flagged a couple issues with the |
Thanks @KineticTheory - just tried to fix these. |
Sorry - I missed one linter error - fixing now. |
If those lint warnings are confusing, here's the scoop: https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md |
9067275
to
171b589
Compare
This might be useful? https://dlaa.me/markdownlint/ |
This is a useful reference - thank you! |
Background
x3d_generator
supports 3D file output, so what is needed is a 3D mesh type in mesh_types.pyPurpose of Pull Request
Description of changes
Status