Fix gcc-based build on ATS-2 and add preliminary env for new machine. #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ PR lanl#1073 fixed an issue related to the new `srun` environments on Toss3 machines but it also introduced a configure error for gcc-based builds on ATS-2. + Update logic in `setupMPI.cmake` to account for more ways of discovering the MPI vendor version. + Also, introduce very preliminary environment support for rzNevada.
Codecov Report
@@ Coverage Diff @@
## develop #1074 +/- ##
=======================================
Coverage 88.6% 88.6%
=======================================
Files 374 374
Lines 18577 18577
=======================================
Hits 16477 16477
Misses 2100 2100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
srunenvironments on Toss3 machines but it also introduced a configure error for gcc-based builds on ATS-2.Purpose of Pull Request
Description of changes
setupMPI.cmaketo account for more ways of discovering the MPI vendor version.Status