Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -g for all builds, including Release. #1072

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Jun 16, 2021

Background

  • During a planning meeting several developers and stakeholders requested that -g be enabled for all builds.

Description of changes

  • This change was made for all Linux builds.
  • Touched cmake files were reformatted with cmake-format.

Status

@KineticTheory KineticTheory added this to the Draco-7_11_0 milestone Jun 16, 2021
@KineticTheory KineticTheory self-assigned this Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1072 (12678ee) into develop (00f53cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1072   +/-   ##
=======================================
  Coverage     88.6%   88.6%           
=======================================
  Files          374     374           
  Lines        18532   18532           
=======================================
  Hits         16432   16432           
  Misses        2100    2100           

@KineticTheory
Copy link
Collaborator Author

@clevelam @jhchang-lanl This is ready to be merged. It enables -g for all builds.

@jhchang-lanl jhchang-lanl merged commit f004039 into lanl:develop Jun 22, 2021
@KineticTheory KineticTheory deleted the always_use_dash_g branch June 22, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants