Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Only append -bind-to none if it is not already present in MPIEXEC_PRE… #1031

Closed
wants to merge 1 commit into from

Conversation

keadyk
Copy link
Collaborator

@keadyk keadyk commented Feb 23, 2021

…FLAGS

Background

  • Running cmake . without blowing away causes "-bind-to none" to be appended to MPIEXEC_PREFLAGS over and over again (I was up to 8 repeats in my local build before I noticed!)
  • I don't know if this is the "right" solution, but it seems to work.

Purpose of Pull Request

Description of changes

  • item

Status

@keadyk
Copy link
Collaborator Author

keadyk commented Feb 23, 2021

@KineticTheory If this is a reasonable solution I can add it in the other places this pattern appears - if not, let me know!

@keadyk keadyk closed this Feb 23, 2021
@keadyk
Copy link
Collaborator Author

keadyk commented Feb 23, 2021

Hahaha, never mind @KineticTheory, I see this fix was added to your last PR. The nice thing for me is that we fixed it in the exact same way! I am heartened :D

@KineticTheory
Copy link
Collaborator

Sorry about that bug. I'm not sure how we missed it for so long. Since the regressions build from scratch, they didn't catch the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants