Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Script Option to Pre/Post Script & Change MPI Call #856

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Add Script Option to Pre/Post Script & Change MPI Call #856

merged 2 commits into from
Jun 19, 2024

Conversation

rstyd
Copy link
Collaborator

@rstyd rstyd commented Jun 18, 2024

This PR addresses #845. It makes /bin/bash the default shell and changes the approach we use for MPI.

@rstyd rstyd requested review from jtronge and kchilleri June 18, 2024 13:59
jtronge
jtronge approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@jtronge jtronge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested the comd-mpi workflow with this and it works.

kchilleri
kchilleri approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@kchilleri kchilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new beeflow:ScriptRequirement shell option, this works for me!

@jtronge jtronge merged commit 086e9db into develop Jun 19, 2024
6 checks passed
@kchilleri kchilleri mentioned this pull request Jul 16, 2024
Merged
@pagrubel pagrubel deleted the worker_shell branch January 8, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtronge jtronge jtronge approved these changes

@kchilleri kchilleri kchilleri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstyd @jtronge @kchilleri