Update starting point for nonconvex #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mohamed82008, digging into the issue of the Ipopt being different I found my hunch was correct and the starting point was the source of the discrepancy. I had presumed the default starting value for variables in Nonconvex was
0.0
, however it appears to be the variables lower bound, unless it is unbounded in which case it is 0.0.I tried updating the same starting point used in the other models (all variables start at 0.0, except
vm
which is set to 1.0). This change broke the implementation and Ipopt would not converge. I presume due to the point discussed here, JuliaNonconvex/Nonconvex.jl#140Using starting values of 1.0 for all variables seemed to be a reasonable compromise as the solver converged in a similar number of iterations to what is expected.
CC @odow