Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compacted hessian_lagrangian #14

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

odow
Copy link
Collaborator

@odow odow commented Apr 7, 2022

Closes #13

@ccoffrin this was what I was talking about.

@codecov-commenter
Copy link

Codecov Report

Merging #14 (3c181a6) into master (26241fa) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   97.92%   97.98%   +0.06%     
==========================================
  Files           3        3              
  Lines         433      446      +13     
==========================================
+ Hits          424      437      +13     
  Misses          9        9              
Impacted Files Coverage Δ
src/nonlinear_oracle.jl 97.73% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26241fa...3c181a6. Read the comment docs.

@odow odow merged commit 3d8b48a into master Apr 7, 2022
@odow odow deleted the od/hessian-sparsity branch April 7, 2022 08:40
@odow
Copy link
Collaborator Author

odow commented Apr 7, 2022

Can you try a new benchmark run on the latest master? I'm seeing massively reduced hessian counts, so it'd be interesting to see if this is the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Hessian sparsity idea discussed with coffrin
2 participants